Re: [Xen-devel] [PATCH] xen: credit2: cleanup patch for type betterness

[George Dunlap <george.dunlap@xxxxxxxxxx>]

On 11/04/17 19:08, Praveen Kumar wrote:
> The patch actually doesn't impact the functionality as such. This only 
> replaces
> bool_t with bool in credit2.
> 
> Signed-off-by: Praveen Kumar <kpraveen.lkml@xxxxxxxxx>

Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>

Julien, is this sort of thing allowed in at this point?  It's not
exactly a bugfix, but it's not exactly a big functional risk either.

I've already got a patch from Praveen queued up for 4.10, so it's not
that much extra effort to hold it either.

 -George

> ---
>  xen/common/sched_credit2.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c
> index ee7b443f9e..1dfed923d3 100644
> --- a/xen/common/sched_credit2.c
> +++ b/xen/common/sched_credit2.c
> @@ -639,17 +639,17 @@ static void deactivate_runqueue(struct csched2_private 
> *prv, int rqi)
>      __cpumask_clear_cpu(rqi, &prv->active_queues);
>  }
>  
> -static inline bool_t same_node(unsigned int cpua, unsigned int cpub)
> +static inline bool same_node(unsigned int cpua, unsigned int cpub)
>  {
>      return cpu_to_node(cpua) == cpu_to_node(cpub);
>  }
>  
> -static inline bool_t same_socket(unsigned int cpua, unsigned int cpub)
> +static inline bool same_socket(unsigned int cpua, unsigned int cpub)
>  {
>      return cpu_to_socket(cpua) == cpu_to_socket(cpub);
>  }
>  
> -static inline bool_t same_core(unsigned int cpua, unsigned int cpub)
> +static inline bool same_core(unsigned int cpua, unsigned int cpub)
>  {
>      return same_socket(cpua, cpub) &&
>             cpu_to_core(cpua) == cpu_to_core(cpub);
> @@ -1882,7 +1882,7 @@ static void migrate(const struct scheduler *ops,
>   *  - svc is not already flagged to migrate,
>   *  - if svc is allowed to run on at least one of the pcpus of rqd.
>   */
> -static bool_t vcpu_is_migrateable(struct csched2_vcpu *svc,
> +static bool vcpu_is_migrateable(struct csched2_vcpu *svc,
>                                    struct csched2_runqueue_data *rqd)
>  {
>      struct vcpu *v = svc->vcpu;
> @@ -1900,7 +1900,7 @@ static void balance_load(const struct scheduler *ops, 
> int cpu, s_time_t now)
>      struct csched2_private *prv = csched2_priv(ops);
>      int i, max_delta_rqi = -1;
>      struct list_head *push_iter, *pull_iter;
> -    bool_t inner_load_updated = 0;
> +    bool inner_load_updated = 0;
>  
>      balance_state_t st = { .best_push_svc = NULL, .best_pull_svc = NULL };
>  
> @@ -2584,7 +2584,7 @@ runq_candidate(struct csched2_runqueue_data *rqd,
>   */
>  static struct task_slice
>  csched2_schedule(
> -    const struct scheduler *ops, s_time_t now, bool_t tasklet_work_scheduled)
> +    const struct scheduler *ops, s_time_t now, bool tasklet_work_scheduled)
>  {
>      const int cpu = smp_processor_id();
>      struct csched2_runqueue_data *rqd;
> @@ -2592,7 +2592,7 @@ csched2_schedule(
>      struct csched2_vcpu *snext = NULL;
>      unsigned int skipped_vcpus = 0;
>      struct task_slice ret;
> -    bool_t tickled;
> +    bool tickled;
>  
>      SCHED_STAT_CRANK(schedule);
>      CSCHED2_VCPU_CHECK(current);
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel