[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v10 13/25] x86: refactor psr: L3 CAT: set value: implement write msr flow.
>>> On 01.04.17 at 15:53, <yi.y.sun@xxxxxxxxxxxxxxx> wrote: > +static void do_write_psr_msr(void *data) > +{ > + struct cos_write_info *info = data; > + unsigned int cos = info->cos; > + struct feat_node *feat = info->feature; > + > + if ( cos > feat->props->cos_max ) > + return; This check can as well be done in the caller, allowing to avoid the IPI in case it's true. > + feat->props->write_msr(cos, info->val, feat); Once the function consists of just this I wonder if it wasn't better to invoke the hook directly from write_psr_msr(). Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |