[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH for-4.9] xsm: fix clang 3.5 build after c47d1d
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>
- From: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
- Date: Mon, 10 Apr 2017 10:42:32 -0400
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Julien Grall <julien.grall@xxxxxxx>, Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>
- Delivery-date: Mon, 10 Apr 2017 14:42:57 +0000
- Ironport-phdr: 9a23:0hpBjx8pllVrmv9uRHKM819IXTAuvvDOBiVQ1KB+0uoRIJqq85mqBkHD//Il1AaPBtSFrasewLWG+4nbGkU4qa6bt34DdJEeHzQksu4x2zIaPcieFEfgJ+TrZSFpVO5LVVti4m3peRMNQJW2aFLduGC94iAPERvjKwV1Ov71GonPhMiryuy+4ZPebgFJiTanfL9+Mhq6oAfSu8ILnYZsN6E9xwfTrHBVYepW32RoJVySnxb4+Mi9+YNo/jpTtfw86cNOSL32cKskQ7NWCjQmKH0169bwtRbfVwuP52ATXXsQnxFVHgXK9hD6XpP2sivnqupw3TSRMMPqQbwoXzmp8rxmQwH0higZKzE58XnXis1ug6JdvBKhvAF0z4rNbI2IKPZyYqbRcNUUSmpbWsZaSjJPDIWyYYASC+YNJPhUo5X4q1YIsBCwBxSjBPn3xzFVmHH206000+MiHw/I0gMvENABv2jbotjuKKcfU/q4wLXUwTjNb/5b3yr25ojSchAmpPGBRbx+ftDXyUkuCQzFikibp4L7MDiI1+oNqXKU4PBuVemyjGMotg5xrSWxyccjkInGnJkYykzE9CplwIY1Ise0SEhgYdG+CpdQuCaaN5VvT84kXmpmuz46x6UbtZO0cyUG0pQqywPFZ/CZfIWE/AjvWPuXLDxlnnxqYqi/iAy38UW4z+38UdS730hSoypel9nMqmgN1xvO6sibUvd9/lmu2TKI1w3L9uFLO1o0lavGK5462LIwipoSvljDHi/xgkn2irOZdl449eSy7uTnY7HmqoedN49ylA7+LrwjltGwDOk3KAQDX3WX9f6i2LDs40H1WqhGguUzkqbDsZDaIcobprS+Aw9Qyoss9hm/ACq439QXh3kINklIeA6Hjof1O1HOJ+r0DfGkg1u2ijtryPfGPqP5DpXXMnfDiKvhfap660NE0gozyt9f6IxOCr0bOPL8QFLxucfEAR84Lwy02efnCdpn2owCXmKPB7eTMLnOvl+Q+uIvP+6MaZcRtjvgNfcl+vrujX4lll8dZqSpxoYXaGumEfh8P0qZZn/siM8bEWgWpgo+UPDqiFqaXD5RenayW6M86S89CI68AofDXJqigLiF3CqgBJJWfGVGBkqQHnfvcoWOQ+0MZz6KIs99jjwEUqCsSoA/2hGorQP11qRoLvTK9S0crp/j0Nl15/bPlREp7zB1ANqS02eVT2FumWMIRSE507xjoUBnzVeDy6d4ieRCFdNP//NJThs6NZnEwuxmEd/yXxjOfsyTRFaiXNqmBz4xT9IvzN8KeEt8Gsutjhbf3yqrDb8VlqCECIYo/aLb2niib/p6nkzB26Q7x2EvX4NqMmugi+Yr7Q/cCpSPi0yEv62rab4dzGjG82LViSKstUcQegNtVaTOXThLRGHbsND47UPqVKK1BPIsNQ4XmuCYLa4fRtTvjFhCDNvucPvEamu/0zO8ChqFyamFRJb7cGUamiPGAQ4LlB5FriXODhQ3Gir0+zGWNzdpD1+6Jhq2qeQ=
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On 04/10/2017 04:41 AM, Roger Pau Monne wrote:
On Fri, Apr 07, 2017 at 08:54:59AM -0600, Jan Beulich wrote:
On 07.04.17 at 16:34, <roger.pau@xxxxxxxxxx> wrote:
The changes introduced on c47d1d broke the clang build due to undefined
references to __xsm_action_mismatch_detected, because clang hasn't optimized
the code properly.
This starts to become annoying.
Yes, tell me about it... I don't think we can blame clang for those failures
anyway. Xen is relying on optimizations to do compile time validations, and
AFAIK this is a grey area. There's nothing in the C spec that guarantees you
that those calls will be removed.
Anyway, will send a new version shortly.
If this problem expands more, I think it would be best to restrict the check to
a particular compiler or #define (as long as it's one used in the build bot);
there's no need to do this kind of check on every build as long as it's done on
occasional builds. Alternatively, it could be done by a static analysis tool,
but I've not looked into how to do that with Coverity.
--
Daniel De Graaf
National Security Agency
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel
|
