Re: [Xen-devel] [PATCH v2 4/7] xen/tools: tracing: add record for credit1 runqueue stealing.

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Fri, 2017-04-07 at 12:01 +0100, George Dunlap wrote:
> On 06/04/17 09:16, Dario Faggioli wrote:
> > 
> > --- a/xen/common/sched_credit.c
> > +++ b/xen/common/sched_credit.c
> > @@ -1738,14 +1739,17 @@ csched_load_balance(struct csched_private
> > *prv, int cpu,
> >                   * balancing and trying to lock this CPU.
> >                   */
> >                  spinlock_t *lock =
> > pcpu_schedule_trylock(peer_cpu);
> > -
> > +                SCHED_STAT_CRANK(steal_trylock);
> >                  if ( !lock )
> >                  {
> >                      SCHED_STAT_CRANK(steal_trylock_failed);
> > +                    TRACE_2D(TRC_CSCHED_STEAL_CHECK, peer_cpu, /*
> > skipp'n */ 0);
> 
> Was this to try to keep the line under 80 characters? :-)
> 
Well, that _and_ being cool! :-P :-P

> I think you could write "skipped" here and it would be the same
> number
> of characters; or just "skip" would be fine too.
>
It's a lot less cool, but ok, go for it. :-D

>   Let me know what you
> think and I can change it on check-in.
> 
Well, I'm preparing a v3, where I'm addressing the comments you're
making, so I'm happy to change this in there too.

> Acked-by: George Dunlap <george.dunlap@xxxxxxxxxx>
> 
Thanks,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel