Re: [Xen-devel] [PATCH for-4.9] xen: append -Wno-unused-function to C99 header check

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Apr 06, 2017 at 09:51:32AM -0700, Stefano Stabellini wrote:
> On Thu, 6 Apr 2017, Jan Beulich wrote:
> > >>> On 06.04.17 at 14:54, <wei.liu2@xxxxxxxxxx> wrote:
> > > --- a/xen/include/Makefile
> > > +++ b/xen/include/Makefile
> > > @@ -111,7 +111,7 @@ headers.chk: $(PUBLIC_ANSI_HEADERS) Makefile
> > >  headers99.chk: $(PUBLIC_C99_HEADERS) Makefile
> > >   rm -f $@.new
> > >   $(foreach i, $(filter %.h,$^),                                        \
> > > -     $(CC) -x c -std=c99 -Wall -Werror                                 \
> > > +     $(CC) -x c -std=c99 -Wall -Werror -Wno-unused-function            \
> > >       -include stdint.h $(foreach j, $($(i)-prereq), -include $(j).h)   \
> > >       -S -o /dev/null $(i)                                              \
> > >       || exit $$?; echo $(i) >> $@.new;)
> > 
> > I think it would be better to make this match the C++ check, where
> > a source file is being generated on the fly (and quite possibly for a
> > similar reason).
>  
> I don't have an opinion on what is the best way to fix this. However,
> I'll say that it is expected to have unused functions in header files
> (it would be a problem if there weren't), so -Wno-unused-function looks
> fine to me.
> 
> Wei, given that the problem was introduced by my patch, let me know if
> you need any help fixing this.
> 

No need. I have another patch queued up for posting -- waiting for
report from travis.

Wei.

> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> https://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel