[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH for-4.9] xen: append -Wno-unused-function to C99 header check
On Thu, 6 Apr 2017, Jan Beulich wrote: > >>> On 06.04.17 at 14:54, <wei.liu2@xxxxxxxxxx> wrote: > > --- a/xen/include/Makefile > > +++ b/xen/include/Makefile > > @@ -111,7 +111,7 @@ headers.chk: $(PUBLIC_ANSI_HEADERS) Makefile > > headers99.chk: $(PUBLIC_C99_HEADERS) Makefile > > rm -f $@.new > > $(foreach i, $(filter %.h,$^), \ > > - $(CC) -x c -std=c99 -Wall -Werror \ > > + $(CC) -x c -std=c99 -Wall -Werror -Wno-unused-function \ > > -include stdint.h $(foreach j, $($(i)-prereq), -include $(j).h) \ > > -S -o /dev/null $(i) \ > > || exit $$?; echo $(i) >> $@.new;) > > I think it would be better to make this match the C++ check, where > a source file is being generated on the fly (and quite possibly for a > similar reason). I don't have an opinion on what is the best way to fix this. However, I'll say that it is expected to have unused functions in header files (it would be a problem if there weren't), so -Wno-unused-function looks fine to me. Wei, given that the problem was introduced by my patch, let me know if you need any help fixing this. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |