[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v2 for-4.9 1/6] x86/hvm: Correct some address space terminology
>>> On 05.04.17 at 19:32, <andrew.cooper3@xxxxxxxxxx> wrote: > The function hvm_translate_linear_addr() translates a virtual address to a > linear address, not a linear address to a physical address. Correct its name. > > Both hvm_translate_virtual_addr() and hvmemul_virtual_to_linear() return a > linear address, but a parameter name of paddr is easily confused with paddr_t. > Rename it to linear, to clearly identify the address space, and for > consistency with hvm_virtual_to_linear_addr(). > > No functional change. > > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> > Reviewed-by: Paul Durrant <paul.durrant@xxxxxxxxxx> > --- > CC: Jan Beulich <JBeulich@xxxxxxxx> > CC: Tim Deegan <tim@xxxxxxx> > CC: Julien Grall <julien.grall@xxxxxxx> > > v2: > * Alter commit message, as there is disagreement as to the intended meaning > of paddr. Whatever the intended meaning, it is currently confusing against > paddr_t. And as said on irc - you could have kept my R-b despite not doing the originally requested parameter name change, so here it is again: Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx> Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |