Re: [Xen-devel] [PATCH] x86/setup: enclose opt_dom0_shadow in CONFIG_SHADOW_PAGING

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Mar 27, 2017 at 08:22:34AM -0600, Jan Beulich wrote:
> >>> On 27.03.17 at 16:12, <wei.liu2@xxxxxxxxxx> wrote:
> > --- a/xen/arch/x86/setup.c
> > +++ b/xen/arch/x86/setup.c
> > @@ -1561,7 +1561,11 @@ void __init noreturn __start_xen(unsigned long mbi_p)
> >      if ( dom0_pvh )
> >      {
> >          domcr_flags |= DOMCRF_hvm |
> > -                       ((hvm_funcs.hap_supported && !opt_dom0_shadow) ?
> > +                       ((hvm_funcs.hap_supported
> > +#ifdef CONFIG_SHADOW_PAGING
> > +                         && !opt_dom0_shadow
> > +#endif
> > +                           ) ?
> 
> Why? It's #define-s to false in that case.
> 

Right. This patch can be ignored. asm-x86/setup.h defines it to false.

> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel