Re: [Xen-devel] [PATCH] x86: remove shadow dom0 command line option

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Mar 24, 2017 at 06:34:14PM +0000, Roger Pau Monné wrote:
[...]
> > > > > It's always been possible to specify dom0=pvh,shadow since PVHv2 Dom0 
> > > > > was
> > > > > introduced, there's no change here at all.
> > > > 
> > > > If dom0= has never been released, then we can change it however we like.
> > > > 
> > > > In that case, we need to update the docs to reflect that.
> > > 
> > > If what you want to do is make dom0=shadow imply pvh, I think that's 
> > > wrong.
> > > IMHO dom0=shadow alone shouldn't be valid, and should always be
> > > dom0=shadow,pvh, as I noted in the comment I've made to the command line
> > > documentation and the code that checks the dom0=... string.
> > > 
> > 
> > But the doc as-is suggests it is either "pvh" or "shadow". Or did I
> > misunderstand your intent?
> 
> Oh, then it's my fault for wording this incorrectly. This option takes a list
> of the following sub-options, like the "iommu" option.
> 

Hmm...

"List" is a defined data type. When you say "list of ...", it is clearly
defined. But the way those options are presented is a bit confusing to
me.

Normally I would use "," instead of "|" to separate those elements. But
I guess that is just my personal taste.

> > What I suggest is the doc should be updated to
> > 
> >   = pvh[,shadow]
> 
> Not sure if we want to make the pvh sub-option mandatory, maybe at some point
> we will also add pv specific sub-options to this list?
> 

OK. (Not going to bikeshed this any further)

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel