Re: [Xen-devel] [PATCH] xen: sched: don't call hooks of the wrong scheduler via VCPU2OP

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Fri, 2017-03-17 at 06:28 +0100, Juergen Gross wrote:
> On 16/03/17 22:30, Dario Faggioli wrote:
> > [..]
> > Fix this by taking care, in VCPU2OP, of the case
> > when the vcpu is an idle one.
> > 
> > Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> 
> Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
> 
Thanks. I won't apply this tag to v2 though, as I'm changing the patch
a bit, as a result of Jan's comment.

> ... with or without the remark below addressed.
> 
About this...

> > --- a/xen/common/schedule.c
> > +++ b/xen/common/schedule.c
> > @@ -78,7 +78,19 @@ static struct scheduler __read_mostly ops;
> >            : (typeof((opsptr)->fn(opsptr, ##__VA_ARGS__)))0 )
> >  
> >  #define DOM2OP(_d)    (((_d)->cpupool == NULL) ? &ops : ((_d)-
> > >cpupool->sched))
> > -#define VCPU2OP(_v)   (DOM2OP((_v)->domain))
> > +static inline struct scheduler* VCPU2OP(const struct vcpu *v)
> 
> Rename, e.g. get_scheduler() ?
> 
I indeed like the idea, and will do that. But in another patch (which
I'll include when posting v2). In fact, since I want this to be
backported, I don't want to change too much code around, making future
backports more difficult.

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel