Re: [Xen-devel] [PATCH] common/mem_access: merged mem_access setting interfaces

[Tamas K Lengyel <tamas@xxxxxxxxxxxxx>]

diff --git a/xen/include/public/memory.h b/xen/include/public/memory.h
index 6eee0c8..ca53a0c 100644
--- a/xen/include/public/memory.h
+++ b/xen/include/public/memory.h
@@ -444,6 +444,8 @@ struct xen_mem_access_op {
     /* xenmem_access_t */
     uint8_t access;
     domid_t domid;
+    uint16_t view_id;
+    uint16_t pad;

I think this will mess with the next uint32_t struct member, so either this pad should be uint16_t pad[3], or another pad needs to be added after the following uint32_t nr.

 

     /*
      * Number of pages for set op (or size of pfn_list for
      * XENMEM_access_op_set_access_multi)
--
1.9.1

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel