Re: [Xen-devel] [PATCH v4 15/17] x86emul: support PCLMULQDQ

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 01.03.17 at 18:44, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 28/02/17 12:58, Jan Beulich wrote:
>> @@ -7434,6 +7436,14 @@ x86_emulate(
>>          generate_exception_if(vex.l, EXC_UD);
>>          goto simd_0f_imm8_avx;
>>  
>> +    case X86EMUL_OPC_66(0x0f3a, 0x44):     /* pclmulqdq $imm8,xmm/m128,xmm 
>> */
>> +    case X86EMUL_OPC_VEX_66(0x0f3a, 0x44): /* vpclmulqdq 
>> $imm8,xmm/m128,xmm,xmm */
>> +        host_and_vcpu_must_have(pclmulqdq);
>> +        if ( vex.opcx == vex_none )
>> +            goto simd_0f3a_common;
> 
> What is this for?  There are no other instructions defined (that I can
> find) in 0f3a44.

Perhaps I'm misunderstanding the question. Are you mixing up
vex.opcx and vex.pfx? We want the non-VEX case handled by
the code at simd_0f3a_common, and the VEX one by the code
further down.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel