Re: [Xen-devel] [RFC PATCH v1 06/21] ARM: NUMA: Parse CPU NUMA information

[Julien Grall <julien.grall@xxxxxxx>]

Hello Vijay,

On 22/02/17 10:46, Vijay Kilari wrote:
> On Mon, Feb 20, 2017 at 11:02 PM, Julien Grall <julien.grall@xxxxxxx> wrote:
> > On 09/02/17 15:56, vijay.kilari@xxxxxxxxx wrote:
> > > From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxx>
> > >
> > > Parse CPU node and fetch numa-node-id information.
> > > For each node-id found, update nodemask_t mask.
> >
> > A link to the bindings would have been useful...
> >
> > > Call numa_init() from setup_mm() with start and end
> > > pfn of the complete ram..
> >
> > s/.././
> >
> >
> > > Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxx>
> > > ---
> > >  xen/arch/arm/Makefile         |  1 +
> > >  xen/arch/arm/bootfdt.c        |  8 ++---
> > >  xen/arch/arm/dt_numa.c        | 72
> > > +++++++++++++++++++++++++++++++++++++++++++
> > >  xen/arch/arm/numa.c           | 14 +++++++++
> > >  xen/arch/arm/setup.c          |  3 ++
> > >  xen/include/asm-arm/numa.h    | 14 +++++++++
> > >  xen/include/xen/device_tree.h |  4 +++
> > >  7 files changed, 112 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
> > > index b5d7a19..7694485 100644
> > > --- a/xen/arch/arm/Makefile
> > > +++ b/xen/arch/arm/Makefile
> > > @@ -50,6 +50,7 @@ obj-y += vtimer.o
> > >  obj-y += vpsci.o
> > >  obj-y += vuart.o
> > >  obj-$(CONFIG_NUMA) += numa.o
> > > +obj-$(CONFIG_NUMA) += dt_numa.o
> >
> > I would prefer if we introduce a directly numa within arm. This would make
> > the root cleaner.
> As it is very specific to DT, I have introduced in this file. ACPI is
> implemented
> in separate file. Common arm specific numa code is in numa.c file.
Sorry I meant separate directory not not "directly".

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel