Re: [Xen-devel] [RFC PATCH v1 04/21] NUMA: Refactor generic and arch specific code of numa_setup

[Julien Grall <julien.grall@xxxxxxx>]

Hello Vijay,

On 22/02/17 10:27, Vijay Kilari wrote:
> On Mon, Feb 20, 2017 at 7:09 PM, Julien Grall <julien.grall@xxxxxxx> wrote:
> > On 09/02/17 15:56, vijay.kilari@xxxxxxxxx wrote:
> > > @@ -145,13 +141,8 @@ void __init numa_initmem_init(unsigned long
> > > start_pfn, unsigned long end_pfn)
> > >                      (u64)end_pfn << PAGE_SHIFT);
> > >  }
> > >
> > > -/* [numa=off] */
> > > -static __init int numa_setup(char *opt)
> > > +int __init arch_numa_setup(char *opt)
> >
> > I don't understand why you split numa_setup. All the options look valid for
> > ARM.
> OK.  This is all valid for arm, provided CONFIG_NUMA_EMU is implemented.
> Can be moved to generic and for now we can keep CONFIG_NUMA_EMU
> disabled for arm.
Why do you want to keep CONFIG_NUMA_EMU disabled on ARM? This is really 
useful to test NUMA code on non-NUMA platform.
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel