Re: [Xen-devel] [PATCH v3 04/11] x86emul/test: use x86-vendors.h

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 01.02.17 at 14:13, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 01/02/17 13:09, Jan Beulich wrote:
>>>>> On 01.02.17 at 13:02, <wei.liu2@xxxxxxxxxx> wrote:
>>> --- a/tools/fuzz/x86_instruction_emulator/Makefile
>>> +++ b/tools/fuzz/x86_instruction_emulator/Makefile
>>> @@ -11,10 +11,15 @@ endif
>>>  x86_emulate/x86_emulate.c x86_emulate/x86_emulate.h:
>>>     [ -L x86_emulate ] || ln -sf $(XEN_ROOT)/xen/arch/x86/x86_emulate .
>>>  
>>> +asm/x86-vendors.h:
>>> +   [ -L asm ] || ln -sf $(XEN_ROOT)/xen/include/asm-x86 asm
>> Hmm, that's making all headers available. I don't really like it to
>> be that broad. Andrew, what do you think
> 
> This is just a test utility.  I think we can trust ourselves to only
> include appropriate headers.
> 
> This is simpler and easier than keeping a whitelist of permitted
> headers, which doesn't require any modification when we add a new header.

Well, okay then (albeit this "doesn't require any modification"
doesn't hold with the dependency the patch also adds; perhaps
midterm we should arrange for the compiler to generate
dependencies for us).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel