Re: [Xen-devel] [PATCH v3 04/11] x86emul/test: use x86-vendors.h

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 01.02.17 at 13:02, <wei.liu2@xxxxxxxxxx> wrote:
> --- a/tools/fuzz/x86_instruction_emulator/Makefile
> +++ b/tools/fuzz/x86_instruction_emulator/Makefile
> @@ -11,10 +11,15 @@ endif
>  x86_emulate/x86_emulate.c x86_emulate/x86_emulate.h:
>       [ -L x86_emulate ] || ln -sf $(XEN_ROOT)/xen/arch/x86/x86_emulate .
>  
> +asm/x86-vendors.h:
> +     [ -L asm ] || ln -sf $(XEN_ROOT)/xen/include/asm-x86 asm

Hmm, that's making all headers available. I don't really like it to
be that broad. Andrew, what do you think

> -CFLAGS += $(CFLAGS_xeninclude) -D__XEN_TOOLS__
> +CFLAGS += $(CFLAGS_xeninclude) -D__XEN_TOOLS__ -I.
> +
> +x86_emulate.h: asm/x86-vendors.h

That's not a true dependency; I'd rather see this build on the
suggested macroization (i.e. introduce it here too, and do the
same for the non-fuzzing harness).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel