Re: [Xen-devel] [PATCH v5 3/9] xen/x86: split Dom0 build into PV and PVHv2

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.01.17 at 18:29, <roger.pau@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/domain_build.c
> +++ b/xen/arch/x86/domain_build.c
> @@ -191,11 +191,40 @@ struct vcpu *__init alloc_dom0_vcpu0(struct domain 
> *dom0)
>  }
>  
>  #ifdef CONFIG_SHADOW_PAGING
> -static bool_t __initdata opt_dom0_shadow;
> +bool __initdata opt_dom0_shadow;
>  boolean_param("dom0_shadow", opt_dom0_shadow);
>  #else
> -#define opt_dom0_shadow 0
> +#define opt_dom0_shadow false

No need to duplicate the #define from the header here.

> @@ -1008,12 +1037,8 @@ int __init construct_dom0(
>      paddr_t mpt_alloc;
>  
>      /* Sanity! */
> -    BUG_ON(d->domain_id != 0);
> -    BUG_ON(d->vcpu[0] == NULL);
>      BUG_ON(v->is_initialised);

What about this last one?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel