Re: [Xen-devel] [PATCH v5 3/9] xen/x86: split Dom0 build into PV and PVHv2

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 20/01/17 19:13, Boris Ostrovsky wrote:
>> diff --git a/xen/arch/x86/domain_build.c b/xen/arch/x86/domain_build.c
>> index 243df96..4d555b1 100644
>> --- a/xen/arch/x86/domain_build.c
>> +++ b/xen/arch/x86/domain_build.c
>> @@ -191,11 +191,40 @@ struct vcpu *__init alloc_dom0_vcpu0(struct domain 
>> *dom0)
>>  }
>>  
>>  #ifdef CONFIG_SHADOW_PAGING
>> -static bool_t __initdata opt_dom0_shadow;
>> +bool __initdata opt_dom0_shadow;
>>  boolean_param("dom0_shadow", opt_dom0_shadow);
> This (boolean_param) is not needed any longer.

Yes it is, for backwards compatibility.

Which is a good point.  The docs change should be modified still refer
to it, mark it as deprecated, and point at dom0=shadow.

>
>
>
>> diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
>> index 0ccef1d..f52f269 100644
>> --- a/xen/arch/x86/setup.c
>> +++ b/xen/arch/x86/setup.c
>> @@ -1545,6 +1545,15 @@ void __init noreturn __start_xen(unsigned long mbi_p)
>>      if ( opt_dom0pvh )
>>          domcr_flags |= DOMCRF_pvh | DOMCRF_hap;
>>  
>> +    if ( dom0_pvh )
>> +    {
>> +        panic("Building a PVHv2 Dom0 is not yet supported.");
>> +        domcr_flags |= DOMCRF_hvm |
>> +                       ((hvm_funcs.hap_supported && !opt_dom0_shadow) ?
>> +                         DOMCRF_hap : 0);
>
> This probably has been discussed already --- are we going to support
> shadow paging for PVH?

ISTR agreeing that it should stay.  Not point excluding something which
already works and is already supported in other cases.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel