Re: [Xen-devel] [PATCH v4 22/24] tools: L2 CAT: support show cbm for L2 CAT.

[Yi Sun <yi.y.sun@xxxxxxxxxxxxxxx>]

On 17-01-06 12:04:43, Wei Liu wrote:
> On Wed, Dec 14, 2016 at 12:08:02PM +0800, Yi Sun wrote:
> > - 'xl psr-cat-show' is updated to show CBM of a domain
> >   according to input cache level.
> > 
> > Examples:
> > root@:~$ xl psr-cat-show -l2 1
> > Socket ID       : 0
> > Default CBM     : 0xff
> >    ID                     NAME             CBM
> >     1                 ubuntu14            0x7f
> > 
> > Signed-off-by: He Chen <he.chen@xxxxxxxxxxxxxxx>
> > Signed-off-by: Yi Sun <yi.y.sun@xxxxxxxxxxxxxxx>
> > ---
> >  tools/libxc/include/xenctrl.h |  1 +
> >  tools/libxc/xc_psr.c          |  3 ++
> >  tools/libxl/libxl_types.idl   |  1 +
> >  tools/libxl/xl_cmdimpl.c      | 81 
> > ++++++++++++++++++++++++++++---------------
> >  tools/libxl/xl_cmdtable.c     |  3 +-
> >  5 files changed, 60 insertions(+), 29 deletions(-)
> > 
> > diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
> > index a32c751..944b7d4 100644
> > --- a/tools/libxl/libxl_types.idl
> > +++ b/tools/libxl/libxl_types.idl
> > @@ -898,6 +898,7 @@ libxl_psr_cbm_type = Enumeration("psr_cbm_type", [
> >      (1, "L3_CBM"),
> >      (2, "L3_CBM_CODE"),
> >      (3, "L3_CBM_DATA"),
> > +    (4, "L2_CBM"),
> 
> Need a LIBXL_HAVE macro.
> 
It has been defined in pathc 21, like below.
tools/libxl/libxl.h
#define LIBXL_HAVE_PSR_L2_CAT 1

> And a very stupid question: where is the libxl code to use this?
> 
> Wei.

L2_CBM is used in xl_cmdimpl.c, like below.
static void psr_cat_print_one_domain_cbm(uint32_t domid, uint32_t socketid,
                                         bool cdp_enabled, unsigned int lvl)
{
......
    case 2:
        psr_cat_print_one_domain_cbm_type(domid, socketid,
                                          LIBXL_PSR_CBM_TYPE_L2_CBM);
......
}

int main_psr_cat_cbm_set(int argc, char **argv)
{
......
    if (lvl == 2)
        type = LIBXL_PSR_CBM_TYPE_L2_CBM;
......
}

Thanks,
Sun Yi

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel