Re: [Xen-devel] [PATCH v4 22/24] tools: L2 CAT: support show cbm for L2 CAT.

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Dec 14, 2016 at 12:08:02PM +0800, Yi Sun wrote:
> This patch implements changes in xl/xc changes to support
> showing CBM of L2 CAT.
> 
> The new level option is introduced to original CAT showing
> command in order to show CBM for specified level CAT.
> - 'xl psr-cat-show' is updated to show CBM of a domain
>   according to input cache level.
> 
> Examples:
> root@:~$ xl psr-cat-show -l2 1
> Socket ID       : 0
> Default CBM     : 0xff
>    ID                     NAME             CBM
>     1                 ubuntu14            0x7f
> 
> Signed-off-by: He Chen <he.chen@xxxxxxxxxxxxxxx>
> Signed-off-by: Yi Sun <yi.y.sun@xxxxxxxxxxxxxxx>
> ---
>  tools/libxc/include/xenctrl.h |  1 +
>  tools/libxc/xc_psr.c          |  3 ++
>  tools/libxl/libxl_types.idl   |  1 +
>  tools/libxl/xl_cmdimpl.c      | 81 
> ++++++++++++++++++++++++++++---------------
>  tools/libxl/xl_cmdtable.c     |  3 +-
>  5 files changed, 60 insertions(+), 29 deletions(-)
> 
> diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include/xenctrl.h
> index 5b7df22..c1675d8 100644
> --- a/tools/libxc/include/xenctrl.h
> +++ b/tools/libxc/include/xenctrl.h
> @@ -2602,6 +2602,7 @@ enum xc_psr_cat_type {
>      XC_PSR_CAT_L3_CBM      = 1,
>      XC_PSR_CAT_L3_CBM_CODE = 2,
>      XC_PSR_CAT_L3_CBM_DATA = 3,
> +    XC_PSR_CAT_L2_CBM      = 4,
>  };
>  typedef enum xc_psr_cat_type xc_psr_cat_type;
>  
> diff --git a/tools/libxc/xc_psr.c b/tools/libxc/xc_psr.c
> index 7af17d9..fe494b0 100644
> --- a/tools/libxc/xc_psr.c
> +++ b/tools/libxc/xc_psr.c
> @@ -299,6 +299,9 @@ int xc_psr_cat_get_domain_data(xc_interface *xch, 
> uint32_t domid,
>      case XC_PSR_CAT_L3_CBM_DATA:
>          cmd = XEN_DOMCTL_PSR_CAT_OP_GET_L3_DATA;
>          break;
> +    case XC_PSR_CAT_L2_CBM:
> +        cmd = XEN_DOMCTL_PSR_CAT_OP_GET_L2_CBM;
> +        break;
>      default:
>          errno = EINVAL;
>          return -1;
> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
> index a32c751..944b7d4 100644
> --- a/tools/libxl/libxl_types.idl
> +++ b/tools/libxl/libxl_types.idl
> @@ -898,6 +898,7 @@ libxl_psr_cbm_type = Enumeration("psr_cbm_type", [
>      (1, "L3_CBM"),
>      (2, "L3_CBM_CODE"),
>      (3, "L3_CBM_DATA"),
> +    (4, "L2_CBM"),

Need a LIBXL_HAVE macro.

And a very stupid question: where is the libxl code to use this?

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel