[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 1/2] x86/paging: Update paging_mark_dirty() to use mfn_t
On 14/12/16 15:13, Jan Beulich wrote: >>>> On 14.12.16 at 15:26, <andrew.cooper3@xxxxxxxxxx> wrote: >> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> >> --- >> CC: Jan Beulich <JBeulich@xxxxxxxx> >> CC: Tim Deegan <tim@xxxxxxx> >> CC: George Dunlap <george.dunlap@xxxxxxxxxxxxx> >> CC: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> >> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx> >> CC: Julien Grall <julien.grall@xxxxxxx> >> >> The one use of paging_mark_dirty() in common/tmem shows that TMEM currently >> wont compile for ARM. > I don't understand: It builds prior to this change, so why would it > stop building afterwards? Without this remark I'd have given my > R-b ... Oh. cli_{get,put}_page() are stubbed to ASSERT(0) on ARM, which restricts the paging_mark_dirty() call to !ARM. The history is weird here. The last change here was you taking out the __ia64__ code. I can't work out why they should be stubbed separately; there is nothing overly x86-specific in them. Konrad: Any ideas? ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |