Re: [Xen-devel] [PATCH 3/4] [STUBDOM] Added COPYING files and README.source files

[Lars Kurth <lars.kurth@xxxxxxxxxx>]

On 24/08/2016 06:10, "Wei Liu" <wei.liu2@xxxxxxxxxx> wrote:

>
>> diff --git a/stubdom/vtpmmgr/README.source
>>b/stubdom/vtpmmgr/README.source
>> new file mode 100644
>> index 0000000..1b45997
>> --- /dev/null
>> +++ b/stubdom/vtpmmgr/README.source
>> @@ -0,0 +1,23 @@
>> +About
>> +=====
>> +This documents the upstream sources for files in this directory.
>> +
>> +The following files are based off of the original
>> +tools/vtpm_manager code base in xen.git, which has since been
>> +deleted: 
>> +
>
>It doesn't seem obvious to me during my archeology.
>
>tools/vtpm_manager was deleted in
>b918dce5bb2a665a34ff893a9df5392fb8ea429d, but it is not clear whether
>your claim (the new code based off the deleted files) is true.
>
>For one, there is no uuid.h in the deleted code -- apparently vtpm
>wouldn't have to ship its own uuid library because OS has one. But then,
>there is such claim in the new uuid.h, so I'm rather confused. I'm
>inclined to believe that this uuid.h is either written afresh or
>imported from somewhere else.
>
>It would also be helpful if you can post your methodology for getting
>the list of file so that I can check if there is something either you or
>I miss.

I merely copied the claims from the existing (c) header files in the
files below, which all say

  5 * based off of the original tools/vtpm_manager code base which is:
  6 * Copyright (c) 2005, Intel Corp.
  7 * All rights reserved.


So I was merely restating the information, which was already present,
assuming that it is in fact correct. Uuid.h seems to have been introduced
in the same commit as all the files below.

>
>New line please.

Will fix the newline and other issues.

Lars

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel