Re: [Xen-devel] [PATCH 3/4] [STUBDOM] Added COPYING files and README.source files

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Aug 24, 2016 at 11:10:02AM +0100, Wei Liu wrote:
> On Fri, Aug 12, 2016 at 06:32:35PM +0100, Lars Kurth wrote:
> > Added a COPYING file as a boilerplate to explain license oddities in
> > this directory
> > 
> > Added a vtpm/COPYING file which contains MIT licensed files only
> > 
> > Added a vtpmmgr/README.source file which contains many BSD-3-Clause
> > files that originally came from tools/vtpm_manager
> > 
> > Signed-off-by: Lars Kurth <lars.kurth@xxxxxxxxxx>
> > ---
> >  stubdom/COPYING               | 31 +++++++++++++++++++++++++++++++
> >  stubdom/vtpm/COPYING          | 26 ++++++++++++++++++++++++++
> >  stubdom/vtpmmgr/README.source | 23 +++++++++++++++++++++++
> >  3 files changed, 80 insertions(+)
> >  create mode 100644 stubdom/COPYING
> >  create mode 100644 stubdom/vtpm/COPYING
> >  create mode 100644 stubdom/vtpmmgr/README.source
> > 
> > diff --git a/stubdom/COPYING b/stubdom/COPYING
> > new file mode 100644
> > index 0000000..a5071b3
> > --- /dev/null
> > +++ b/stubdom/COPYING
> > @@ -0,0 +1,31 @@
> > +Most files in this directory are covered by version 2 of the 
> > +GNU General Public License except where explicitly stated.
> > +See the main COPYING file in xen.git for more information.
> > +
> > +Notable exceptions are in the following directories
> > +
> > +vtpm
> > +==== 
> > +Exclusively contains code licensed under a MIT license
> > +Also see vtpm/COPYING
> > +
> > +vtpmmgr
> > +=======
> > +Contains a significant portion of files which are licensed
> > +under a BSD-3-Clause license. These files were imported from
> > +elsewhere and are copyrighted as follows:
> > +
> > +Copyright (c) 2005, Intel Corp.
> > +All rights reserved.
> > +
> > +See README.source for a complete list of files
> > +
> > +Otherwise, this directory contains several files licensed under
> > +GPLv2+, or without copyright headers. 
> > +
> > +*.patch and *.diff files
> > +========================
> > +This directory contains a number of *.patch and *.diff files. 
> > +These files describe changes to source files and are thus 
> > +licensed under the license from which the *.patch and *.diff
> > +were generated.
> > diff --git a/stubdom/vtpm/COPYING b/stubdom/vtpm/COPYING
> > new file mode 100644
> > index 0000000..80780b8
> > --- /dev/null
> > +++ b/stubdom/vtpm/COPYING
> > @@ -0,0 +1,26 @@
> > +This copyright applies to all files within this subdirectory and its
> > +subdirectories, unless explicitly stated otherwise within individual 
> > +source files.
> > +
> > +All other files in the Xen source distribution are covered by version
> > +2 of the GNU General Public License except where explicitly stated.
> > +See the main COPYING file in xen.git for more information.
> > +
> > +=====================================================================
> > +
> > +Permission is hereby granted, free of charge, to any person obtaining a 
> > copy
> > +of this software and associated documentation files (the "Software"), to
> > +deal in the Software without restriction, including without limitation the
> > +rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
> > +sell copies of the Software, and to permit persons to whom the Software is
> > +furnished to do so, subject to the following conditions:
> > +
> > +The above copyright notice and this permission notice shall be included in
> > +all copies or substantial portions of the Software.
> > +
> > +THIS SOFTWARE AND ITS DOCUMENTATION ARE PROVIDED AS IS AND WITHOUT
> > +ANY EXPRESS OR IMPLIED WARRANTIES WHATSOEVER. ALL WARRANTIES
> > +INCLUDING, BUT NOT LIMITED TO, PERFORMANCE, MERCHANTABILITY, FITNESS
> > +FOR A PARTICULAR  PURPOSE, AND NONINFRINGEMENT ARE HEREBY
> > +DISCLAIMED. USERS ASSUME THE ENTIRE RISK AND LIABILITY OF USING THE
> > +SOFTWARE.
> > \ No newline at end of file
> 
> Here, please add a new line.
> 
> > diff --git a/stubdom/vtpmmgr/README.source b/stubdom/vtpmmgr/README.source
> > new file mode 100644
> > index 0000000..1b45997
> > --- /dev/null
> > +++ b/stubdom/vtpmmgr/README.source
> > @@ -0,0 +1,23 @@
> > +About
> > +=====
> > +This documents the upstream sources for files in this directory.
> > +
> > +The following files are based off of the original 
> > +tools/vtpm_manager code base in xen.git, which has since been 
> > +deleted: 
> > +
> 
> It doesn't seem obvious to me during my archeology.
> 
> tools/vtpm_manager was deleted in
> b918dce5bb2a665a34ff893a9df5392fb8ea429d, but it is not clear whether
> your claim (the new code based off the deleted files) is true.
> 
> For one, there is no uuid.h in the deleted code -- apparently vtpm
> wouldn't have to ship its own uuid library because OS has one. But then,
> there is such claim in the new uuid.h, so I'm rather confused. I'm
> inclined to believe that this uuid.h is either written afresh or
> imported from somewhere else.
> 

For uuid.h, the code resembles neither Linux's nor FreeBSD's.  The
closest thing I can find is libxl_uuid.h. If that's the case, my
understanding is that he license, depending on when the code is
imported, can be either GPL or LGPL...

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel