[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/3] x86emul: don't open code EFLAGS handling for 2-operand IMUL

To: Jan Beulich <JBeulich@xxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Date: Tue, 16 Aug 2016 15:20:35 +0100
Delivery-date: Tue, 16 Aug 2016 14:20:50 +0000
List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 16/08/16 10:33, Jan Beulich wrote:

Slightly extending the emulate_2op*() macro machinery makes it usable
for IMUL r,r/m too, which has the benefit of smaller source code and
the EFLAGS output being guaranteed to match actual hardware behavior.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> (I think - reviewing this just re-enforces my view of how horribly opaque this bit of the emulator is)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

References:
- [Xen-devel] [PATCH 0/3] x86emul: further misc small adjustments
  - From: Jan Beulich
- [Xen-devel] [PATCH 2/3] x86emul: don't open code EFLAGS handling for 2-operand IMUL
  - From: Jan Beulich

Prev by Date: Re: [Xen-devel] [PATCH 1/3] x86emul: use DstEax also for {, I}{MUL, DIV}
Next by Date: Re: [Xen-devel] [PATCH 3/3] x86emul: re-order main 2-byte opcode switch() statement
Previous by thread: [Xen-devel] [PATCH 2/3] x86emul: don't open code EFLAGS handling for 2-operand IMUL
Next by thread: [Xen-devel] [PATCH 3/3] x86emul: re-order main 2-byte opcode switch() statement
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.