Re: [Xen-devel] [PATCH 1/3] x86emul: use DstEax also for {, I}{MUL, DIV}

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 16/08/16 10:32, Jan Beulich wrote:
> Just like said in commit c0bc0adf24 ("x86emul: use DstEax where
> possible"): While it avoids just a few instructions, we should
> nevertheless make use of generic code as much as possible.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

This does reduce the amount of code, but it isn't strictly true.  The
mul and div instructions are DstEaxEdx, as are a number of other
instructions.

We shouldn't end up with special casing the eax part because we have an
easy literal for it, but leaving the edx hard coded because that is
easier to express in the current code.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel