Re: [Xen-devel] [PATCH v2 2/2] tools: make xenstore domain easy configurable

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Juergen Gross writes ("[PATCH v2 2/2] tools: make xenstore domain easy 
configurable"):
> Add configuration entries to sysconfig.xencommons for selection of the
> xenstore type (domain or daemon) and start the selected xenstore
> service via a script called from sysvinit or systemd.

Can you please split this up into two patches,
 * Break launch-xenstore out of xencommons (no functional change)
 * Use launch-xenstore instead of sockets with systemd
?

As ever it's a lot easier to review the functional change when it's
not mixed in with code motion.

I suspect that the latter mnay need to be combined with parts of what
is currently 1/2, since AFAICT after applying 1 nothing starts
xenstored any more under systemd.

(Also your patch again contains a patch to configure but no
corresponding patch to the source file(s).)

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel