Re: [Xen-devel] [PATCH v2 1/2] tools: remove systemd xenstore socket definitions

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Juergen Gross writes ("[PATCH v2 1/2] tools: remove systemd xenstore socket 
definitions"):
> On a system with systemd the xenstore sockets are created via systemd.
> Remove the related configuration files in order to be able to decide
> at runtime whether the sockets should be created or not. This will
> enable Xen to start xenstore either via a daemon or via a stub domain.

The core parts of this look OK to me.  I think this needs an ack from
Dave Scott.  I'd also like to invite comments from any systemd
experts.

However:

> diff --git a/tools/configure b/tools/configure
> index 5b5dcce..a04fe3f 100755
> --- a/tools/configure
> +++ b/tools/configure

Where is the corresponding original source change for this hunk ?
You need to include that.  (Also please write a note in the commit
message to remind the committer to rerun autogen.sh.)

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel