Re: [Xen-devel] [PATCH 7/7] vm-event/arm: implement support for control-register write vm-events

[Julien Grall <julien.grall@xxxxxxx>]

Hello Corneliu,

On 16/06/16 15:13, Corneliu ZUZU wrote:
> Add ARM support for control-register write monitoring through the vm-events
> subsystem.
>
> Chosen ARM system control-registers that can be monitored are:
>      - VM_EVENT_ARM_SCTLR:      AArch32 SCTLR, AArch64 SCTLR_EL1
>      - VM_EVENT_ARM_TTBR{0,1}:  AArch32 TTBR{0,1}, AArch64 TTBR{0,1}_EL1
>      - VM_EVENT_ARM_TTBCR:      AArch32 TTBCR, AArch64 TCR_EL1
>
> Trapping of write operations of these registers was attained by setting the
> HCR_EL2.TVM / HCR.TVM bit.
>
> Signed-off-by: Corneliu ZUZU <czuzu@xxxxxxxxxxxxxxx>
> ---
>   MAINTAINERS                    |   1 +
>   xen/arch/arm/Makefile          |   1 +
>   xen/arch/arm/traps.c           | 126 +++++++++++++++++++-
>   xen/arch/arm/vm_event.c        | 112 ++++++++++++++++++
>   xen/common/monitor.c           |   2 -
>   xen/common/vm_event.c          |   2 -
>   xen/include/asm-arm/domain.h   |  30 +++++
>   xen/include/asm-arm/traps.h    | 253 +++++++++++++++++++++++++++++++++++++++++
>   xen/include/asm-arm/vm_event.h |  22 +++-
>   xen/include/public/vm_event.h  |   8 +-
>   xen/include/xen/monitor.h      |   2 -
>   xen/include/xen/vm_event.h     |   2 -
>   12 files changed, 543 insertions(+), 18 deletions(-)
I think this patch would benefit to be split in multiple patches to ease 
the review and also describe the infrastructure you have introduced 
(TVM_* & co).
I will review in detail later.

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel