Re: [Xen-devel] [PATCH 1/7] minor (formatting) fixes

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.06.16 at 16:06, <czuzu@xxxxxxxxxxxxxxx> wrote:
> --- a/xen/arch/x86/hvm/event.c
> +++ b/xen/arch/x86/hvm/event.c
> @@ -23,6 +23,7 @@
>  
>  #include <xen/vm_event.h>
>  #include <asm/hvm/event.h>
> +#include <asm/paging.h>
>  #include <asm/monitor.h>
>  #include <asm/vm_event.h>
>  #include <public/vm_event.h>
> diff --git a/xen/common/monitor.c b/xen/common/monitor.c
> index d950a7c..b30857a 100644
> --- a/xen/common/monitor.c
> +++ b/xen/common/monitor.c
> @@ -22,7 +22,6 @@
>  #include <xen/monitor.h>
>  #include <xen/sched.h>
>  #include <xsm/xsm.h>
> -#include <public/domctl.h>
>  #include <asm/monitor.h>
>  #include <asm/vm_event.h>

These two adjustments clearly don't fit title / description. I certainly
don't mind unnecessary inclusions to be dropped, but the addition of
one clearly needs explanation (after all thing build fine without it).

> --- a/xen/include/asm-x86/vm_event.h
> +++ b/xen/include/asm-x86/vm_event.h
> @@ -44,6 +44,9 @@ void vm_event_set_registers(struct vcpu *v, 
> vm_event_response_t *rsp);
>  
>  void vm_event_fill_regs(vm_event_request_t *req);
>  
> +/*
> + * Monitor vm-events.
> + */

This is a single line comment (also elsewhere).

> --- a/xen/include/xen/vm_event.h
> +++ b/xen/include/xen/vm_event.h
> @@ -85,7 +85,6 @@ void vm_event_monitor_guest_request(void);
>  
>  #endif /* __VM_EVENT_H__ */
>  
> -
>  /*
>   * Local variables:
>   * mode: C

Why don't you remove the other stray blank line at once?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel