Re: [Xen-devel] [PATCH 2/2] nested vmx: Validate host VMX MSRs before accessing them

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.06.16 at 12:14, <euan.harris@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/hvm/vmx/vvmx.c
> +++ b/xen/arch/x86/hvm/vmx/vvmx.c
> @@ -1820,11 +1820,20 @@ int nvmx_msr_read_intercept(unsigned int msr, u64 
> *msr_content)
>          return 0;
>  
>      /*
> -     * Those MSRs are available only when bit 55 of
> -     * MSR_IA32_VMX_BASIC is set.
> +     * These MSRs are only available when flags in other MSRs are set.
> +     * These prerequisites are listed in the Intel 64 and IA-32
> +     * Architectures Software Developer’s Manual, Vol 3, Appendix A.
>       */
> -    switch ( msr )
> -    {
> +    switch ( msr ) { case MSR_IA32_VMX_PROCBASED_CTLS2:

I hope you didn't really mean to produce a garbled line like this?
With proper formatting restored
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel