Re: [Xen-devel] [PATCH] xen/vsprintf: Avoid returning NULL from number()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.06.16 at 12:00, <andrew.cooper3@xxxxxxxxxx> wrote:
> In practice this is an unused codepath, as every caller of number() passes an
> explicit base of 8, 10 or 16.  For all other uses, number() returns a 
> pointer
> between the str and end parameters, as do the other similar helper 
> functions.
> 
> However, the fact that there is a NULL return path causes Coverity to check
> whether the caller makes NULL checks on the return value, and complain.
> 
> Change the conditional return into an ASSERT().
> 
> No functional change, but this removes 21 instances of NULL_RETURN in
> Coverity.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

But should really have Cc-ed the other REST maintainers.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel