Re: [Xen-devel] [PATCH RESEND 03/14] libxc: Add placeholders for ACPI tables blob and size

[Julien Grall <julien.grall@xxxxxxx>]

Hello Shannon,

On 31/05/16 06:02, Shannon Zhao wrote:
> From: Shannon Zhao <shannon.zhao@xxxxxxxxxx>
>
> Currently it only needs ACPI table RSDP, XSDT, GTDT, MADT, FADT, DSDT
> for ARM VM. So only add placeholders for them here.
>
> Signed-off-by: Shannon Zhao <shannon.zhao@xxxxxxxxxx>
> ---
>   tools/libxc/include/xc_dom.h | 17 +++++++++++++++++
>   1 file changed, 17 insertions(+)
>
> diff --git a/tools/libxc/include/xc_dom.h b/tools/libxc/include/xc_dom.h
> index 6cb10c4..0fe54dd 100644
> --- a/tools/libxc/include/xc_dom.h
> +++ b/tools/libxc/include/xc_dom.h
> @@ -56,6 +56,20 @@ struct xc_dom_phys {
>       xen_pfn_t count;
>   };
>
> +struct acpitable {
> +    void *table;
> +    size_t size;
> +};
> +
> +struct acpitable_blob {
> +    struct acpitable rsdp;
> +    struct acpitable xsdt;
> +    struct acpitable gtdt;
> +    struct acpitable madt;
> +    struct acpitable fadt;
> +    struct acpitable dsdt;
> +};
Is there any particular reason to expose the list of the tables outside 
of the building code?
I would provide a single buffer with all the tables inside. Similar to 
what you did for building the tables in the hypervisor.
> +
>   struct xc_dom_image {
>       /* files */
>       void *kernel_blob;
> @@ -64,6 +78,8 @@ struct xc_dom_image {
>       size_t ramdisk_size;
>       void *devicetree_blob;
>       size_t devicetree_size;
> +    struct acpitable_blob *acpitable_blob;
> +    size_t acpitable_size;
>
>       size_t max_kernel_size;
>       size_t max_ramdisk_size;
> @@ -92,6 +108,7 @@ struct xc_dom_image {
>       struct xc_dom_seg p2m_seg;
>       struct xc_dom_seg pgtables_seg;
>       struct xc_dom_seg devicetree_seg;
> +    struct xc_dom_seg acpi_seg;
>       struct xc_dom_seg start_info_seg; /* HVMlite only */
>       xen_pfn_t start_info_pfn;
>       xen_pfn_t console_pfn;
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel