Re: [Xen-devel] [PATCH RESEND 05/14] libxl/arm: Construct ACPI GTDT table

[Julien Grall <julien.grall@xxxxxxx>]

Hello,

On 06/06/16 13:18, Wei Liu wrote:
> On Tue, May 31, 2016 at 01:02:57PM +0800, Shannon Zhao wrote:
> > +static int prepare_acpi(libxl__gc *gc, libxl_domain_build_info *info,
> > +                        libxl__domain_build_state *state,
> > +                        struct xc_dom_image *dom)
> libxl__prepare_acpi
>
> I would also suggest moving ACPI related functions to a dedicated file
> (libxl_arm_acpi.c) so that the possible future merger with x86 code can
> be made easier.
+1 and it makes sense to have the code to build the Device Tree and the 
ACPI tables in a separate files.
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel