Re: [Xen-devel] [RFC for-4.8 v2 2/7] xen/arm: Rename and generalize un/map_regions_rw_cache

[Julien Grall <julien.grall@xxxxxxx>]

Hi Edgar,

On 03/06/16 14:29, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias" <edgar.iglesias@xxxxxxxxxx>
>
> Rename and generalize un/map_regions_rw_cache into
> un/map_regions.
I would name it map_regions_mattr (or something similar) to stop people 
using this helper to map real RAM.
> The new functions take the mapping
> attributes and access permissions as arguments.
I overlooked it when I reviewed {,un}map_regions_rw_cache. p2m_access_t 
is for memaccess to restrict the permission. The helper should always 
use d->arch.p2m.default_access.
Can you fix it in a separate patch and request for backport to Xen 4.7?

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel