Re: [Xen-devel] [PATCH for-4.7] libxl: keep PoD target adjustment by memory fudge after reload_domain_config()

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("[Xen-devel] [PATCH for-4.7] libxl: keep PoD target adjustment 
by memory fudge after reload_domain_config()"):
> From: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>
> 
> Commit 56fb5fd623 ("libxl: adjust PoD target by memory fudge, too")
> introduced target_memkb adjustment for HVM PoD domains on create. The
> adjustment is however being reset on reload_domain_config() (e.g. when
> we reboot the guest). For example:

With George's revised commit message this patch makes sense for 4.7.

I would like to see this function retain the name "fudge" though:

> -    ents[3] = GCSPRINTF("%"PRId64, info->target_memkb - info->video_memkb
> -                        - mem_target_fudge);
> +    ents[3] = GCSPRINTF("%"PRId64, info->target_memkb -
> +                        libxl__get_targetmem_difference(gc, info));

ie:

  +    ents[3] = GCSPRINTF("%"PRId64, info->target_memkb -
  +                        libxl__get_targetmem_fudge(gc, info));

This makes it clear that there is still a problem here (and it will
help things like "git grep -G").

With that name changed, and George's commit message, you may put my
ack on this.


George writes:

> better fix will have to wait until after the release.
 
Realistically speaking, that is quite optimistic.  Empirically, we
keep squelching into the memory accounting swamp, but we have as yet
failed to drain it.  Instead our code keeps accreting bodges in this
area, and the swamp keeps growing...

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel