Re: [Xen-devel] [PATCH v3 1/7] libxl: improve return codes for some pci related functions

[Wei Liu <wei.liu2@xxxxxxxxxx>]

Apart from what Oalf already said, I have one minor below.

On Wed, Apr 20, 2016 at 10:03:58AM +0200, Paulina Szubarczyk wrote:
> *libxl__device_from_pcidev() initialize the values of libxl__device
>  struct and can be void.
> 
> *libxl__create_pci_backend(), libxl__device_pci_destroy_all()
>  should propagate the success/error, rather than always returning 0.
> 
> Signed-off-by: Paulina Szubarczyk <paulinaszubarczyk@xxxxxxxxx>
> ---
> Changes since v2:
>   - changed the changelog as indicated by Dario.
> ---
>  tools/libxl/libxl_pci.c | 20 +++++++-------------
>  1 file changed, 7 insertions(+), 13 deletions(-)
> 
> diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c
> index 300fd4d..b4be967 100644
> --- a/tools/libxl/libxl_pci.c
> +++ b/tools/libxl/libxl_pci.c
> @@ -64,7 +64,7 @@ static void libxl_create_pci_backend_device(libxl__gc *gc, 
> flexarray_t *back, in
>      flexarray_append_pair(back, GCSPRINTF("state-%d", num), GCSPRINTF("%d", 
> XenbusStateInitialising));
>  }
>  
> -static int libxl__device_from_pcidev(libxl__gc *gc, uint32_t domid,
> +static void libxl__device_from_pcidev(libxl__gc *gc, uint32_t domid,
>                                       libxl_device_pci *pcidev,
>                                       libxl__device *device)

Could you also fix the indentation, please?

Wei.
 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel