Re: [Xen-devel] [PATCH v8.1 07/27] arm/x86: Use struct virtual_region to do bug, symbol, and (x86) exception tables lookup.

["Jan Beulich" <jbeulich@xxxxxxxx>]

>>> Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> 04/14/16 12:04 AM >>>
>+/*
>+ * RCU locking. Additions are done either at startup (when there is only
>+ * one CPU) or when all CPUs are running without IRQs.
>+ *
>+ * Deletions are big tricky. We do it when xSplicing (all CPUs running

"big tricky"?

>+ * without IRQs) or during bootup (when clearing the init).
>+ *
>+ * Hence we use list_del_rcu (which sports an memory fence) and a spinlock
>+ * on deletion.
>+ *
>+ * All readers of virtual_region_list MUST use list list_for_each_entry_rcu.
>+ *
>+ */

Stray empty comment line.

>--- /dev/null
>+++ b/xen/include/xen/virtual_region.h
>@@ -0,0 +1,47 @@
>+/*
>+ * Copyright (c) 2016 Oracle and/or its affiliates. All rights reserved.
>+ *
>+ */
>+
>+#ifndef __XEN_VIRTUAL_REGION__

__XEN_VIRTUAL_REGION_H__

With those minor aspects taken care of,
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel