Re: [Xen-devel] [PATCH v6 14/24] xsplice: Add support for bug frames.

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 07/04/16 04:49, Konrad Rzeszutek Wilk wrote:
> diff --git a/xen/common/xsplice.c b/xen/common/xsplice.c
> index ca650e6..087cb94 100644
> --- a/xen/common/xsplice.c
> +++ b/xen/common/xsplice.c
> @@ -124,6 +124,28 @@ static int verify_payload(const 
> xen_sysctl_xsplice_upload_t *upload, char *n)
>      return 0;
>  }
>  
> +bool_t is_patch(const void *ptr)
> +{
> +    struct payload *data;
> +
> +    /*
> +     * No locking since this list is only ever changed during apply or revert
> +     * context.
> +     */
> +    list_for_each_entry ( data, &applied_list, applied_list )
> +    {

This needs to include a text check, even if it should have no current users.

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

> +        if ( ptr >= data->rw_addr &&
> +             ptr < (data->rw_addr + data->rw_size) )
> +            return 1;
> +
> +        if ( ptr >= data->ro_addr &&
> +             ptr < (data->ro_addr + data->ro_size) )
> +            return 1;
> +    }
> +
> +    return 0;
> +}
> +
>  unsigned long xsplice_symbols_lookup_by_name(const char *symname)
>  {
>      struct payload *data;


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel