Re: [Xen-devel] [PATCH v3 01/28] xen/x86: Drop unused and non-useful feature definitions

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 16/03/16 07:53, Konrad Rzeszutek Wilk wrote:
> On Tue, Mar 15, 2016 at 03:34:57PM +0000, Andrew Cooper wrote:
>> None of these features are interesting for Xen to use, or to be advertised to
>> guests.  Doing so identifies further areas of code which can be removed now
>> that 32bit support has been dropped.
>>
>> IA64 has a sole user in microcode_intel.c.  While it is plausible for a 32bit
>> x86 hypervisor to get there via IA64's x86 emulation, a 64bit x86 hypervisor
>> most certainly won't.
>>
>> MP proves to be more complicated.  It is only advertised on some K7
>> processors, not on K8 or newer, and now listed as reserved in the AMD manual.
>> Cleaning this up reveals two chunks of common SMP code which was only
>> applicable to K7 processors, which are 32bit only.
>>
>> While cleaning this area up, remove the incosistent use of newlines in the
> s/incosistent/inconsistent/

Fixed.

>
>> cpu_has_* definition block.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
>
>> ---
>> CC: Jan Beulich <JBeulich@xxxxxxxx>
>>
>> v3: New
>>
>> This cleanup removes the only users of TAINT_UNSAFE_SMP, but I have left the
>> infrastructure incase it needs to be used in the future.
>> ---
>>  xen/arch/x86/microcode_intel.c   |  3 +--
>>  xen/arch/x86/smpboot.c           | 46 
>> ----------------------------------------
>>  xen/include/asm-x86/cpufeature.h | 18 ----------------
>>  3 files changed, 1 insertion(+), 66 deletions(-)
> Aaah, can't beat those diffstats.

Absolutely not.  Going into this, I was only expecting the -18 from
cpufeature.h

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel