Re: [Xen-devel] [PATCH v5 21/22] xen/arm: Add a hypercall for device mmio mapping

[Shannon Zhao <zhaoshenglong@xxxxxxxxxx>]

On 2016/3/4 18:29, Jan Beulich wrote:
>> > --- a/xen/arch/arm/mm.c
>> > +++ b/xen/arch/arm/mm.c
>> > @@ -1138,6 +1138,9 @@ int xenmem_add_to_physmap_one(
>> >          rcu_unlock_domain(od);
>> >          break;
>> >      }
>> > +    case XENMAPSPACE_dev_mmio:
>> > +        rc = map_dev_mmio_region(d, gpfn, 1, idx);
> This being the only caller, ...
> 
>> > +int map_dev_mmio_region(struct domain *d,
>> > +                        unsigned long start_gfn,
>> > +                        unsigned long nr,
>> > +                        unsigned long mfn)
>> > +{
> ... what's the "nr" parameter good for? 
While currently the caller passes const value 1, but I think it's fine
to make this function support to map multiple pages for future possible use.

Thanks,
-- 
Shannon


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel