Re: [Xen-devel] [PATCH v3 07/16] hvmloader: Grab the hvm_start_info pointer

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.02.16 at 17:37, <JBeulich@xxxxxxxx> wrote:
>>>> On 25.02.16 at 15:56, <anthony.perard@xxxxxxxxxx> wrote:
>> @@ -258,6 +263,7 @@ int main(void)
>>      memset((void *)HYPERCALL_PHYSICAL_ADDRESS, 0xc3 /* RET */, PAGE_SIZE);
>>  
>>      printf("HVM Loader\n");
>> +    BUG_ON(hvm_start_info->magic != XEN_HVM_START_MAGIC_VALUE);
> 
> Wait - public/xen.h clearly says this is being handed for PVH guests
> only. How can you even de-reference the pointer unconditionally?

Ah, I see this is a result of patch 2, which so far I didn't look at
in any detail, the title of which doesn't suggest such a behavioral
change, and which also doesn't update the comment in
public/xen.h.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel