Re: [Xen-devel] [PATCH v10 17/31] primary vm suspend/resume/checkpoint code

[Wen Congyang <wency@xxxxxxxxxxxxxx>]

On 02/25/2016 11:57 PM, Wei Liu wrote:
> On Mon, Feb 22, 2016 at 10:52:21AM +0800, Wen Congyang wrote:
> [...]
>> +#include "libxl_osdeps.h" /* must come before any other headers */
>> +
>> +#include "libxl_internal.h"
>> +#include "libxl_colo.h"
>> +
>> +static const libxl__checkpoint_device_instance_ops *colo_ops[] = {
>> +    NULL,
>> +};
>> +
>> +/* ================= helper functions ================= */
>> +static int init_device_subkind(libxl__checkpoint_devices_state *cds)
>> +{
>> +    /* init device subkind-specific state in the libxl ctx */
>> +    int rc;
>> +    STATE_AO_GC(cds->ao);
>> +
>> +    rc = 0;
>> +    return rc;
>> +}
>> +
>> +static void cleanup_device_subkind(libxl__checkpoint_devices_state *cds)
>> +{
>> +    /* cleanup device subkind-specific state in the libxl ctx */
>> +    STATE_AO_GC(cds->ao);
>> +}
>> +
>> +/* ================= colo: setup save environment ================= */
>> +static void colo_save_setup_done(libxl__egc *egc,
>> +                                 libxl__checkpoint_devices_state *cds,
>> +                                 int rc);
>> +static void colo_save_setup_failed(libxl__egc *egc,
>> +                                   libxl__checkpoint_devices_state *cds,
>> +                                   int rc);
>> +static void libxl__colo_save_domain_suspend_callback(void *data);
>> +static void libxl__colo_save_domain_checkpoint_callback(void *data);
>> +static void libxl__colo_save_domain_resume_callback(void *data);
>> +static void libxl__colo_save_domain_wait_checkpoint_callback(void *data);
>> +
> 
> 
> An ordered list of callbacks is appreciated. This doesn't seem to cover
> all callbacks and I'm not sure if this is the order they are supposed to
> fire either.

OK, I will check it and fix it in the next version.

Thanks
Wen Congyang

> 
> Wei.
> 
> 
> .
> 




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel