[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3] xen: Work around Clang generating .data.rel.ro section for init-only files



>>> On 23.02.16 at 19:36, <andrew.cooper3@xxxxxxxxxx> wrote:
> Clang-3.8 generates several .data.rel.ro sections when compiling Xen.  As
> these contain no global symbols, they should be .data.rel.ro.local.  This
> breaks the SPECIAL_DATA_SECTIONS check when converting the transition units 
> to
> being init-only.
> 
> For alternatives.c, explicitly move the nops arrays into __initconst.  For 
> efi
> boot.c, manually create the optimisation performed by Clang by collapsing 
> the
> switch statement into a lookup table.  The double use of const is required 
> to
> avoid breaking the ARM build by creating a section type conflict with
> fdt_guid.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Build-tested-by: Jan Beulich <jbeulich@xxxxxxxx>

I've also re-worded the second paragraph to refer to the newly
introduced section, and replaced "transition" with "translation" in
the first one. I hope that's okay with you.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.