[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3] xen: Work around Clang generating .data.rel.ro section for init-only files



>>> On 23.02.16 at 19:37, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 23/02/16 18:36, Andrew Cooper wrote:
>> Clang-3.8 generates several .data.rel.ro sections when compiling Xen.  As
>> these contain no global symbols, they should be .data.rel.ro.local.  This
>> breaks the SPECIAL_DATA_SECTIONS check when converting the transition units 
>> to
>> being init-only.
>>
>> For alternatives.c, explicitly move the nops arrays into __initconst.  For 
>> efi
>> boot.c, manually create the optimisation performed by Clang by collapsing the
>> switch statement into a lookup table.  The double use of const is required to
>> avoid breaking the ARM build by creating a section type conflict with
>> fdt_guid.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> ---
>> CC: Jan Beulich <JBeulich@xxxxxxxx>
>>
> 
> Would you mind testing this on whichever older compiler suffered the
> original symptoms?  I can't find such a compiler to test with.

Sure.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.