Re: [Xen-devel] [PATCH] arm: clean up build variables

[Doug Goldstein <cardoe@xxxxxxxxxx>]

On 1/25/16 5:27 AM, Ian Campbell wrote:
> On Wed, 2016-01-20 at 15:47 -0600, Doug Goldstein wrote:
>> This consolidates some of the different variables used for the ARM
>> builds. This change was prompted by the Kconfig changes but looking back
>> in time the CONFIG_ARM_{32,64} variables existed before Kconfig so this
>> should just be a generic cleanup.
>>
>> Signed-off-by: Doug Goldstein <cardoe@xxxxxxxxxx>
>> ---
>>  xen/arch/arm/Makefile            |  8 ++++----
>>  xen/arch/arm/Rules.mk            | 18 ++++--------------
>>  xen/drivers/passthrough/Makefile |  2 +-
>>  3 files changed, 9 insertions(+), 19 deletions(-)
>>
>> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
>> index 2f050f5..0d11c0f 100644
>> --- a/xen/arch/arm/Makefile
>> +++ b/xen/arch/arm/Makefile
>> @@ -1,7 +1,7 @@
>> -subdir-$(arm32) += arm32
>> -subdir-$(arm64) += arm64
>> +subdir-$(CONFIG_ARM_32) += arm32
>> +subdir-$(CONFIG_ARM_64) += arm64
>>  subdir-y += platforms
>> -subdir-$(arm64) += efi
>> +subdir-$(CONFIG_ARM_64) += efi
>>  
>>  obj-$(EARLY_PRINTK) += early_printk.o
>>  obj-y += cpu.o
>> @@ -52,7 +52,7 @@ ALL_OBJS := $(TARGET_SUBARCH)/head.o $(ALL_OBJS)
>>  
>>  $(TARGET): $(TARGET)-syms $(TARGET).axf
>>      $(OBJCOPY) -O binary -S $< $@
>> -ifeq (arm64,$(XEN_TARGET_ARCH))
>> +ifdef CONFIG_ARM_64
> 
> The old way looks to be the prevailing normal form. I don't especially
> object to the change but things ought to remain consistent.

Which part? Using arm32/arm64? Or having the if blocks rather than
var-$(CONFIG_THING) ?

My goal here is consistency and that was to standardize on the form of
var-$(CONFIG_THING) across the board.

> 
> For the rest:
>     Acked-by: Ian Campbell <    ian.campbell@xxxxxxxxxx    >
> 
> FYI I'm not committing things right now due to network issues between the
> machine(s) I use for such things.
> 
> Ian.
> 


-- 
Doug Goldstein

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel