[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] arm: clean up build variables
On Wed, 2016-01-20 at 15:47 -0600, Doug Goldstein wrote: > This consolidates some of the different variables used for the ARM > builds. This change was prompted by the Kconfig changes but looking back > in time the CONFIG_ARM_{32,64} variables existed before Kconfig so this > should just be a generic cleanup. > > Signed-off-by: Doug Goldstein <cardoe@xxxxxxxxxx> > --- > Âxen/arch/arm/MakefileÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ8 ++++---- > Âxen/arch/arm/Rules.mkÂÂÂÂÂÂÂÂÂÂÂÂ| 18 ++++-------------- > Âxen/drivers/passthrough/Makefile |ÂÂ2 +- > Â3 files changed, 9 insertions(+), 19 deletions(-) > > diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile > index 2f050f5..0d11c0f 100644 > --- a/xen/arch/arm/Makefile > +++ b/xen/arch/arm/Makefile > @@ -1,7 +1,7 @@ > -subdir-$(arm32) += arm32 > -subdir-$(arm64) += arm64 > +subdir-$(CONFIG_ARM_32) += arm32 > +subdir-$(CONFIG_ARM_64) += arm64 > Âsubdir-y += platforms > -subdir-$(arm64) += efi > +subdir-$(CONFIG_ARM_64) += efi > Â > Âobj-$(EARLY_PRINTK) += early_printk.o > Âobj-y += cpu.o > @@ -52,7 +52,7 @@ ALL_OBJS := $(TARGET_SUBARCH)/head.o $(ALL_OBJS) > Â > Â$(TARGET): $(TARGET)-syms $(TARGET).axf > Â $(OBJCOPY) -O binary -S $< $@ > -ifeq (arm64,$(XEN_TARGET_ARCH)) > +ifdef CONFIG_ARM_64 The old way looks to be the prevailing normal form. I don't especially object to the change but things ought to remain consistent. For the rest: Acked-by: Ian Campbell < ian.campbell@xxxxxxxxxx > FYI I'm not committing things right now due to network issues between the machine(s) I use for such things. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |