Re: [Xen-devel] [PATCH v3 2/5] libxl: make GC_FREE reachable in libxl_get_scheduler()

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Sun, 2016-01-24 at 19:45 -0500, Chester Lin wrote:
> Coverity CID 1343309
> 
> Make GC_FREE reachable in all cases in libxl_get_scheduler() by
> eliminating the error-path return and instead storing the error code in
> the returned variable.
> 
> To make this semantically consistent, change the return type of
> libxl_get_scheduler() from libxl_scheduler to int, and make a note of
> the interpretation of the return value in libxl.h.ÂÂN.B. This change
> does not change the API in a way that affects functionality.
> 
> The libxl_scheduler enum is consistent with the sched_id return value
> of xc_sched_id and this must continue to be true.
> 
> Suggested-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Signed-off-by: Chester Lin <czylin@xxxxxxxxxxxx>
> Reviewed-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

I can't see any sign of v3 versions of #3, #4 or #5/5 in my INBOX, have
they gone astray?

Also, both #1 and #2 seem to have been sent independently using separate
git send-email invocations. Please send them from one single invocation, as
reply to a cover letter (which may be referenced with --in-reply-to, or
written using --compose) such that they are all properly threaded together
into a message thread.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel