[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH V13 5/5] xl: add pvusb commands
On Thu, Jan 21, 2016 at 12:21:11PM +0000, Ian Campbell wrote: > On Thu, 2016-01-21 at 12:12 +0000, Wei Liu wrote: > > On Tue, Jan 19, 2016 at 08:10:07PM -0700, Jim Fehlig wrote: > > > On 01/19/2016 11:11 AM, Ian Jackson wrote: > > > > Chunyan Liu writes ("[PATCH V13 5/5] xl: add pvusb commands"): > > > > > Add pvusb commands: usbctrl-attach, usbctrl-detach, usb-list, > > > > > usbdev-attach and usbdev-detach. > > > > Thanks for swapping this with the other patch. It is better now. > > > > > > > > > +=item B<usbctrl-attach> I<domain-id> I<usbctrl-device> > > > > However, I think you need to explictly state that the user may (and > > > > indeed, must) pass multiple settings as separate arguments. AFAICT > > > > the parser here doesn't do the ,-splitting. > > > > > > I just noticed this is the case with network devices as well. E.g. > > > > > > #xl network-attach hvm-domU mac=00:16:3e:xx:yy:zz,bridge=br0 > > > libxl: error: libxl_device.c:1095:device_hotplug_child_death_cb: > > > script: Could > > > not find bridge device xenbr0 > > > > > > main_networkattach() in tools/libxl/xl_cmdimpl.c doesn't split on the > > > ',', so > > > everything after mac=00:16:3e:xx:yy:zz is ignored. I'd need advice on > > > how to fix > > > this though. Based on xl-network-configuration doc and Xen tool's long > > > history > > > of network-attach supporting that syntax, I'd say main_networkattach() > > > should be > > > changed to split on ','. I could also change the docs. Do tools > > > maintainers have > > > a preference, or alternative option? > > > > > > > It is splitting on " " at the moment which is not very desirable. > > > > I think this is a bug. I've added it to my list and will look into > > fixing it. > > If you are feeling particularly highly motivated then xl_cmdimpl.c contains > quite a lot of adhoc parsing of various comma a space separated lists > (often dupped for a given instance into cmdline vs cfg file, which leads to > unintentional behavioural differences like above) which could usefully be > consolidated into a series of helpers. > Or rewrite every adhoc parser with bison/flex or Ocaml / Haskell parsec. Jokes aside. I will see what I can do. Consolidating them into helper functions is a good start. Wei. > Ian. > _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |