Re: [Xen-devel] [PATCH] x86/HVM: add padding to hvm_hw_cpu

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 18/01/16 14:39, Roger Pau Monne wrote:
> So that the size of the structure is the same on 32 and 64bit.
>
> Signed-off-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
> ---
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> This should fix the issues seen on OSSTest when using a 32bit toolstack on
> a 64bit hypervisor to create a Windows 7 HVM guest.
> ---
>  xen/include/public/arch-x86/hvm/save.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/xen/include/public/arch-x86/hvm/save.h 
> b/xen/include/public/arch-x86/hvm/save.h
> index b6b1bf8..6862720 100644
> --- a/xen/include/public/arch-x86/hvm/save.h
> +++ b/xen/include/public/arch-x86/hvm/save.h
> @@ -163,6 +163,7 @@ struct hvm_hw_cpu {
>  #define _XEN_X86_FPU_INITIALISED        0
>  #define XEN_X86_FPU_INITIALISED         (1U<<_XEN_X86_FPU_INITIALISED)
>      uint32_t flags;
> +    uint32_t pad0;

I would extend flags to uint64_t, so the existing ctxt.flags &
~XEN_X86_FPU_INITIALISED check for unused bits will cover all of them.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel