[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH RFC OSSTEST v1 07/12] ts-debian-di-install: Allow Di Version to come from runvars
On Tue, 2016-01-12 at 14:39 +0000, Ian Jackson wrote: > Ian Campbell writes ("[PATCH RFC OSSTEST v1 07/12] ts-debian-di-install: > Allow Di Version to come from runvars"): > > and following the lead of the suite arrange for a version selected > > from the defaults to be written back to the runvars. > ... > > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂdebian_guest_suite > > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂdebian_guest_suite debian_guest_diversion > > Can we please call this function, ..._di_version ?ÂÂOtherwise it sounds > very much like something is being diverted. > > > +sub debian_guest_diversion ($) { > > +ÂÂÂÂmy ($gho) = @_; > > + > > +ÂÂÂÂ$gho->{DiVersion} //= guest_var($gho,'diversion',undef); > > + > > +ÂÂÂÂif (!$gho->{DiVersion}) { > > + $gho->{DiVersion} = $c{TftpDiVersion}; > > + store_runvar("$gho->{Guest}_diversion", $gho->{DiVersion}); > > I'm not sure what we should do about the runvar.ÂÂ`diversion' is a bad > name but there is a risk with `..._di_version' getting confused with > all the `..._revision' fields. > > OTOH > > osstestdb=> select distinct name from runvars where name like '%version'; > ÂÂÂÂÂÂÂÂÂname > ÂÂÂÂÂÂÂÂÂ---------------------- > ÂÂÂÂÂÂÂÂÂÂdevice_model_version > ÂÂÂÂÂÂÂÂÂÂ(1 row) > > osstestdb=> > > So maybe guest_di_version would be the right answer. Yes, I think so too, I'll go with that. > Aside from the questions about this name, this patch LGTM. > > Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |